Add semantic coloring example from Android 17#410
Merged
alabiaga merged 3 commits intoandroid:mainfrom May 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the project to Android SDK 37, AGP 9.1.1, Kotlin 2.2.10, and Gradle 9.3.1. It migrates numerous sample modules to Java 11, refactors their build scripts to use a newer DSL structure by moving targetSdk to lint and testOptions blocks, and implements semantic style annotations for notifications. Feedback suggests removing the obsolete android.uniquePackageNames flag and correcting the android.newDsl setting, as it currently contradicts the DSL modernization efforts in the build files.
ashnohe
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll follow up with another refactoring of the build gradle files as there are changes in agp 9.0 dsl that deprecates things and needs migration.
See:
https://developer.android.com/build/migrate-to-built-in-kotlin#kts