Fix factory provisioned cert detection to catch "really old" certs#85
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_930160291
branch
from
c0cb839 to
abee8df
Compare
Factory certificates changed format at some point between 2016 and 2021, which breaks the "isFactoryProvisioned" check. Make the check a bit more lax so that we consider more cert types as factory provisioned. This is safe because we are not relaxing the isRemoteProvisioned check at all, and that is the check that attackers want to spoof. PiperOrigin-RevId: 930722556
copybara-service
Bot
force-pushed
the
test_930160291
branch
from
abee8df to
7f99055
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix factory provisioned cert detection to catch "really old" certs
Factory certificates changed format at some point between 2016 and 2021,
which breaks the "isFactoryProvisioned" check.
Make the check a bit more lax so that we consider more cert types as
factory provisioned. This is safe because we are not relaxing the
isRemoteProvisioned check at all, and that is the check that attackers
want to spoof.