Skip to content

Update to use rememberAmbientModeManager#345

Merged
kul3r4 merged 1 commit into
android:mainfrom
kul3r4:update-ambient
Apr 16, 2026
Merged

Update to use rememberAmbientModeManager#345
kul3r4 merged 1 commit into
android:mainfrom
kul3r4:update-ambient

Conversation

@kul3r4

@kul3r4 kul3r4 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

@kul3r4 kul3r4 requested a review from yschimke April 9, 2026 10:00

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ambient mode handling in the Exercise Sample Compose application. It migrates from the Horologist AmbientState API to the androidx.wear.compose.foundation rememberAmbientModeManager for managing ambient mode. The ambientGray and ambientBlank modifiers were updated to accept a boolean isAmbient parameter. While PreparingExerciseScreen was successfully updated to use the new ambient mode manager, the ExerciseScreen had its ambient mode adaptation removed entirely, which is an oversight as it's part of the always-on routes. This needs to be addressed by re-implementing ambient mode detection and applying the ambientGray modifier to the ExerciseScreen. Additionally, several dependencies were updated to their latest versions.

timeText = { ResponsiveTimeText(timeSource = FixedTimeSource) }
) {
ExerciseScreen(
isAmbient = false,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be true otherwise the state is the same as above (and the screenshot is exactly the same).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! that' updated now

@kul3r4 kul3r4 requested review from ithinkihaveacat and removed request for yschimke April 15, 2026 14:24
@kul3r4 kul3r4 merged commit c48aab5 into android:main Apr 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants