Skip to content

fix: publish-docs input is ignored when set to false - #4

Closed
andrewwhitecdw wants to merge 4 commits into
mainfrom
codequality/release-publish-docs-input-is-ignored-when-set
Closed

fix: publish-docs input is ignored when set to false#4
andrewwhitecdw wants to merge 4 commits into
mainfrom
codequality/release-publish-docs-input-is-ignored-when-set

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Owner

This PR addresses the following issue in .github/workflows/release.yml: publish-docs input is ignored when set to false.

Changes

  • .github/workflows/release.yml: publish-docs input is ignored when set to false.

Details

--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -1,1 +1,1 @@
-      publish-docs: ${{ inputs.publish-docs || true }}
+      publish-docs: ${{ inputs.publish-docs == true }}

Tests

  • tests/test_release_publish_docs.py
--- /dev/null
+++ b/tests/test_release_publish_docs.py
@@ -0,0 +1,16 @@
+import re
+import unittest
+from pathlib import Path
+
+REPO_ROOT = Path(__file__).resolve().parent.parent
+
+
+class TestReleaseWorkflow(unittest.TestCase):
+    def test_publish_docs_respects_false_input(self):
+        workflow = REPO_ROOT / ".github" / "workflows" / "release.yml"
+        text = workflow.read_text()
+        match = re.search(r"^\s+publish-docs:\s*(.+)$", text, re.MULTILINE)
+        self.assertIsNotNone(match)
+        self.assertNotIn("|| true", match.group(1),
+                         "publish-docs always evaluates to true; false input is ignored")
+
+
+if __name__ == "__main__":
+    unittest.main()

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

sudostock and others added 4 commits July 27, 2026 19:37
Reduce experiment directory collisions by using time_ns for generated and reset experiment IDs. Add focused coverage for both paths.

Signed-off-by: Alex Filby <afilby@nvidia.com>
* fix(docker): persist cancellation status

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

* test(docker): cover missing cancellation request

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

* fix(ci): skip release rehearsal for forks

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

---------

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: Andrew White <andrewh@cdw.com>
@andrewwhitecdw

Copy link
Copy Markdown
Owner Author

Closing per adversarial audit: branch contains off-scope or not-a-bug changes.

@andrewwhitecdw
andrewwhitecdw deleted the codequality/release-publish-docs-input-is-ignored-when-set branch August 2, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants