fix: publish-docs toggle forced true so false input is ignored - #3
Closed
andrewwhitecdw wants to merge 5 commits into
Closed
fix: publish-docs toggle forced true so false input is ignored#3andrewwhitecdw wants to merge 5 commits into
andrewwhitecdw wants to merge 5 commits into
Conversation
Reduce experiment directory collisions by using time_ns for generated and reset experiment IDs. Add focused coverage for both paths. Signed-off-by: Alex Filby <afilby@nvidia.com>
* fix(docker): persist cancellation status Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com> * test(docker): cover missing cancellation request Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com> * fix(ci): skip release rehearsal for forks Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com> --------- Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: Andrew White <andrewh@cdw.com>
Auditor: The release.yml change uses `${{ github.event_name == 'workflow_dispatch' ? inputs.publish-docs : true }}`, which is not valid GitHub Actions expression syntax (no ternary operator), so the workflow will fail to parse. Additionally, the PR is far off-scope: it pins action versions across many workflows, makes unrelated experiment timestamp and docker scheduler changes, and modifies release job conditions. Reject as malformed and too large/risky.
Owner
Author
|
Closing after multiple repair attempts: original patch no longer applies or auditor feedback remains unaddressed. |
andrewwhitecdw
deleted the
bugfix/release-publish-docs-toggle-forced-true-so
branch
August 2, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue in
.github/workflows/release.yml: publish-docs toggle forced true so false input is ignored.Changes
.github/workflows/release.yml: publish-docs toggle forced true so false input is ignored.Details
Tests
tests/test_release_publish_docs.pyContributor guidelines
Per this repo's CONTRIBUTING.md:
Signed-off-bytrailer, DCO).