Skip to content

fix: publish-docs toggle forced true so false input is ignored - #3

Closed
andrewwhitecdw wants to merge 5 commits into
mainfrom
bugfix/release-publish-docs-toggle-forced-true-so
Closed

fix: publish-docs toggle forced true so false input is ignored#3
andrewwhitecdw wants to merge 5 commits into
mainfrom
bugfix/release-publish-docs-toggle-forced-true-so

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Owner

This PR addresses the following issue in .github/workflows/release.yml: publish-docs toggle forced true so false input is ignored.

Changes

  • .github/workflows/release.yml: publish-docs toggle forced true so false input is ignored.

Details

--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -1,1 +1,1 @@
-      publish-docs: ${{ inputs.publish-docs || true }}
+      publish-docs: ${{ github.event_name == 'workflow_dispatch' ? inputs.publish-docs : true }}

Tests

  • tests/test_release_publish_docs.py
diff --git a/tests/test_release_publish_docs.py b/tests/test_release_publish_docs.py
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/tests/test_release_publish_docs.py
@@ -0,0 +1,12 @@
+"""Regression test for release.yml publish-docs toggle."""
+import pathlib
+
+RELEASE_YML = pathlib.Path(".github/workflows/release.yml")
+
+
+def test_publish_docs_input_allows_false():
+    content = RELEASE_YML.read_text()
+    forbidden = "publish-docs: ${{ inputs.publish-docs || true }}"
+    assert forbidden not in content, (
+        "publish-docs input is forced to true and cannot be disabled"
+    )

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

sudostock and others added 5 commits July 27, 2026 19:37
Reduce experiment directory collisions by using time_ns for generated and reset experiment IDs. Add focused coverage for both paths.

Signed-off-by: Alex Filby <afilby@nvidia.com>
* fix(docker): persist cancellation status

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

* test(docker): cover missing cancellation request

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

* fix(ci): skip release rehearsal for forks

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

---------

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: Andrew White <andrewh@cdw.com>
Auditor: The release.yml change uses `${{ github.event_name == 'workflow_dispatch' ? inputs.publish-docs : true }}`, which is not valid GitHub Actions expression syntax (no ternary operator), so the workflow will fail to parse. Additionally, the PR is far off-scope: it pins action versions across many workflows, makes unrelated experiment timestamp and docker scheduler changes, and modifies release job conditions. Reject as malformed and too large/risky.
@andrewwhitecdw

Copy link
Copy Markdown
Owner Author

Closing after multiple repair attempts: original patch no longer applies or auditor feedback remains unaddressed.

@andrewwhitecdw
andrewwhitecdw deleted the bugfix/release-publish-docs-toggle-forced-true-so branch August 2, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants