Skip to content

fix: nightly tag job lacks contents:write permission - #2

Closed
andrewwhitecdw wants to merge 4 commits into
mainfrom
codequality/nightly-nightly-tag-job-lacks-contents-write
Closed

fix: nightly tag job lacks contents:write permission#2
andrewwhitecdw wants to merge 4 commits into
mainfrom
codequality/nightly-nightly-tag-job-lacks-contents-write

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Owner

This PR addresses the following issue in .github/workflows/nightly.yml: nightly tag job lacks contents:write permission.

Changes

  • .github/workflows/nightly.yml: nightly tag job lacks contents:write permission.

Details

--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -1,5 +1,7 @@
-  tag:
-    name: Run Tests and Create Nightly Tag
-    runs-on: ubuntu-latest
-    needs: [format, lint, test]
-    steps:
+  tag:
+    name: Run Tests and Create Nightly Tag
+    runs-on: ubuntu-latest
+    needs: [format, lint, test]
+    permissions:
+      contents: write
+    steps:

Tests

  • tests/test_nightly_permissions.py
--- /dev/null
+++ b/tests/test_nightly_permissions.py
@@ -0,0 +1,14 @@
+import unittest
+from pathlib import Path
+
+REPO_ROOT = Path(__file__).resolve().parent.parent
+
+
+class TestNightlyWorkflow(unittest.TestCase):
+    def test_tag_job_has_contents_write(self):
+        workflow = REPO_ROOT / ".github" / "workflows" / "nightly.yml"
+        text = workflow.read_text()
+        self.assertIn("contents: write", text,
+                      "nightly workflow needs contents:write to create/update the nightly tag")
+
+
+if __name__ == "__main__":
+    unittest.main()

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

sudostock and others added 4 commits July 27, 2026 19:37
Reduce experiment directory collisions by using time_ns for generated and reset experiment IDs. Add focused coverage for both paths.

Signed-off-by: Alex Filby <afilby@nvidia.com>
* fix(docker): persist cancellation status

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

* test(docker): cover missing cancellation request

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

* fix(ci): skip release rehearsal for forks

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

---------

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: Andrew White <andrewh@cdw.com>
@andrewwhitecdw

Copy link
Copy Markdown
Owner Author

Closing per adversarial audit: branch contains off-scope or not-a-bug changes.

@andrewwhitecdw
andrewwhitecdw deleted the codequality/nightly-nightly-tag-job-lacks-contents-write branch August 2, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants