Skip to content

fix: cherry-pick workflow triggers on main instead of release branches - #1

Closed
andrewwhitecdw wants to merge 4 commits into
mainfrom
bugfix/cherry-pick-release-commit-cherry-pick-workflow-triggers-on-main
Closed

fix: cherry-pick workflow triggers on main instead of release branches#1
andrewwhitecdw wants to merge 4 commits into
mainfrom
bugfix/cherry-pick-release-commit-cherry-pick-workflow-triggers-on-main

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Owner

This PR addresses the following issue in .github/workflows/cherry-pick-release-commit.yml: cherry-pick workflow triggers on main instead of release branches.

Changes

  • .github/workflows/cherry-pick-release-commit.yml: cherry-pick workflow triggers on main instead of release branches.

Details

--- a/.github/workflows/cherry-pick-release-commit.yml
+++ b/.github/workflows/cherry-pick-release-commit.yml
@@ -1,4 +1,5 @@
-on:
-  push:
-    branches:
-      - main
+on:
+  push:
+    branches:
+      - "[rv][0-9].[0-9].[0-9]"
+      - "[rv][0-9].[0-9].[0-9]rc[0-9]"

Tests

  • tests/test_cherry_pick_trigger.py
diff --git a/tests/test_cherry_pick_trigger.py b/tests/test_cherry_pick_trigger.py
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/tests/test_cherry_pick_trigger.py
@@ -0,0 +1,14 @@
+"""Regression test for cherry-pick workflow trigger."""
+import pathlib
+
+CHERRY_YML = pathlib.Path(".github/workflows/cherry-pick-release-commit.yml")
+
+
+def test_cherry_pick_triggers_on_release_branches():
+    content = CHERRY_YML.read_text()
+    assert "branches:\n      - main" not in content, (
+        "cherry-pick workflow should not trigger only on main"
+    )
+    assert "[rv]" in content, (
+        "cherry-pick workflow should trigger on release branches"
+    )

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

sudostock and others added 4 commits July 27, 2026 19:37
Reduce experiment directory collisions by using time_ns for generated and reset experiment IDs. Add focused coverage for both paths.

Signed-off-by: Alex Filby <afilby@nvidia.com>
* fix(docker): persist cancellation status

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

* test(docker): cover missing cancellation request

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

* fix(ci): skip release rehearsal for forks

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>

---------

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: Andrew White <andrewh@cdw.com>
@andrewwhitecdw

Copy link
Copy Markdown
Owner Author

Closing per adversarial audit: branch contains off-scope or not-a-bug changes.

@andrewwhitecdw
andrewwhitecdw deleted the bugfix/cherry-pick-release-commit-cherry-pick-workflow-triggers-on-main branch August 2, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants