Skip to content

chore: sync upstream through a1e7ac2b24 - #303

Merged
andrewcai8 merged 174 commits into
mainfrom
sync/upstream-a1e7ac2b24
Nov 19, 2026
Merged

andrewcai8 merged 174 commits into
mainfrom
sync/upstream-a1e7ac2b24

Conversation

@andrewcai8

Copy link
Copy Markdown
Owner

Why

Syncs the fork with upstream pingdotgg/t3code through a1e7ac2, upstream's newest main with green CI. That is 171 commits on top of the last sync (#301, 89ac1b8). Merge commit; land with a merge, never squash.

What changed

Conflict resolutions (22 files, 10 of them i18n catalogs):

  • storageCleanup: upstream fix(server): cleanup refreshes the size of a kept orphan worktree pingdotgg/t3code#39017 moved worktree measuring after discovery and refreshes kept sizes. The fork's orphan removal now runs per linked orphan after that measuring, with the same reasons and freed bytes as before.
  • ProjectionStore: upstream's turn-start message read is a UNION of indexed branches. The fork's "queued messages that joined the run share its root node" clause is a third branch on messages_node_idx, so it adds no thread scan.
  • ClaudeAdapterV2: upstream hoisted the terminal status to hold a result while a steer is unread. The fork's limitedEmptyTurn still fails the turn, so a limited wake turn is never held.
  • MCP t3_project_list: keeps viaFleet and Home routing, plus upstream's saved default model.
  • web new-chat picker: upstream skips archived project members. The fork's cloud placement now picks only among those same members.
  • managedProvider: the fork's provider-check permit wraps upstream's DeferringFailedCheck probe.
  • Mobile row, client-runtime exports, server tests: both sides kept. ForkMigrations pins 099/100. The agent context budget is 63932 MCP bytes, the fork's 6611 over base plus upstream's growth (label agent-context-increase).
  • After the merge: a duplicate Clock import in storageCleanup.test.ts; upstream's new NewTaskRouteScreen.test.tsx cases needed the fork's cloud state in their useNewTaskFlow mock.

Blast Radius

Two new upstream migrations. Each CREATE INDEX scans its whole table, and the server answers 503 until they finish.

  • 099 builds a partial index over orchestration_v2_projection_turn_items (failed usage-limit errors). This is the expensive one. The PC has about 5.56M turn items (max rowid, read-only). On a snapshot of the Mac host DB, turn items average 0.67 leaf pages each, so the scan reads about 3.7M pages (about 15 GB). payload_json overflow is read only for the PC's 1,017 failed error rows.
  • 100 builds three partial indexes, over messages (756k rows, about 1.3 GB of leaf pages), subagents (58.6k) and context transfers (56.6k).
  • PC estimate (inferred; the Mac snapshot's warm 45 ms and 13 ms do not predict it): migration 073 scanned turn items twice on a 21 GiB DB and lifted the PC's start to 205 s. The DB is now 82 GiB, so expect 099 to add roughly 5 to 10 minutes and 100 under a minute. That comes on top of the usual 2m40s stop and start. Restart the PC when it is quiet.
  • fix(orchestration): a turn requested during restart no longer stays starting forever #302 (runs stuck in starting across a restart) is merged in from main, unchanged.

Verification

  • vp run typecheck in all 12 packages holding fork-diff files (contracts, shared, provider-core, provider-cursor, source-control-github, client-runtime, server, web, mobile, desktop, evals, scripts).
  • vp fmt --check and vp lint on all 798 files that differ from upstream. vp run knip:check, i18n-check, and the untranslated-copy count (0).
  • Full vp test run of provider-core, client-runtime, contracts and mobile; the 33 fork-touched web test files.
  • Server full suite: 605 of 621 files pass. Rerunning the 16 failing files on origin/main fails the same tests, except 6 whose files are byte-identical to upstream. Four triage cases pass with TMPDIR resolved (tmpdir symlink). Two are file-watcher timeouts on this Mac; one passed on a rerun. ProviderRuntimeRecoveryService.test.ts (fix(orchestration): a turn requested during restart no longer stays starting forever #302) passes on the merged head.

Not verified: a real-client pass, and migration timing on the PC itself. Follow-up: upstream's new PR and CI MCP tools take environmentId but are not wrapped in viaFleet, so a cloud box's agent cannot route them through Home. Claude Opus 5.5 did the sync in Claude Code.

🤖 Generated with Claude Code

juliusmarminge and others added 30 commits November 18, 2026 12:52
…ems (pingdotgg#38263)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
pingdotgg#38544)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ngdotgg#28889)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…8294)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
…#38684)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…38771)

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…tgg#38350)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
…38282)

Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…tgg#29391)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
…35306)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
…otgg#29399)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#26969)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
StiensWout and others added 21 commits November 19, 2026 06:18
… name (pingdotgg#39126)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ndroid (pingdotgg#39128)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… the picker (pingdotgg#39130)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…in thread's digest (pingdotgg#39132)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…rojects both list (pingdotgg#39142)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gg#38038)

Co-authored-by: Claude Haiku 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ssages, tasks and transfers (pingdotgg#39103)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…e workspace folder (pingdotgg#39146)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gdotgg#39150)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ent cleared (pingdotgg#39151)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…te names (pingdotgg#39147)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#39116)

Co-authored-by: Tibor Casteleijn <tibbor.casteleijn@easytrip.eu>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… saves (pingdotgg#39154)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Merge pingdotgg/t3code main through a1e7ac2 (171 commits after 89ac1b8).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@andrewcai8 andrewcai8 added the agent-context-increase Accept agent context growth in agentContextBudget.json label Nov 19, 2026
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XXL labels Nov 19, 2026
@github-actions

Copy link
Copy Markdown

This PR changes the test suite by +238 test cases (browser +20, unit +109, server +109).

New browser test files: apps/web/src/components/issue/IssueLinkPreview.browser.test.tsx.
Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.

Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing.

@github-actions github-actions Bot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.5 KiB 21.5 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Other scenarios

All 64 scenario measurements match main.

All 64 scenario measurements
Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex short turn resume WebSocket decoded 10.5 KiB 10.5 KiB 0 B (0.0%) 12.7 KiB ✅
Codex short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn running, cold open HTTP decoded 281.7 KiB 281.7 KiB 0 B (0.0%) 302.7 KiB ✅
Codex long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Codex long turn running, history page HTTP decoded 92.4 KiB 92.4 KiB 0 B (0.0%) 107.4 KiB ✅
Codex long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Codex long turn finished, cold open HTTP decoded 381.5 KiB 381.5 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, socket cold open WebSocket decoded 381.6 KiB 381.6 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, work page HTTP decoded 186.2 KiB 186.2 KiB 0 B (0.0%) 200.2 KiB ✅
Codex long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Codex idle thread resume WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell snapshot HTTP decoded 42.4 KiB 42.4 KiB 0 B (0.0%) 53.7 KiB ✅
Codex fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Codex fleet shell subscribe WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Codex fleet shell resume check rows 0 0 0 0 ✅
Codex stale shell reload HTTP decoded 42.4 KiB 42.4 KiB 0 B (0.0%) 53.7 KiB ✅
Codex stale shell reload rows 27 27 0 (0.0%) 27 ✅
Codex stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Codex stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex stale todo list cold open HTTP decoded 72.4 KiB 72.4 KiB 0 B (0.0%) 83.0 KiB ✅
Codex stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Codex stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅
Claude short turn resume WebSocket decoded 10.6 KiB 10.6 KiB 0 B (0.0%) 12.7 KiB ✅
Claude short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn running, cold open HTTP decoded 283.3 KiB 283.3 KiB 0 B (0.0%) 302.7 KiB ✅
Claude long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Claude long turn running, history page HTTP decoded 93.4 KiB 93.4 KiB 0 B (0.0%) 107.4 KiB ✅
Claude long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Claude long turn finished, cold open HTTP decoded 384.2 KiB 384.2 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, socket cold open WebSocket decoded 384.3 KiB 384.3 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, work page HTTP decoded 188.1 KiB 188.1 KiB 0 B (0.0%) 200.2 KiB ✅
Claude long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Claude idle thread resume WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell snapshot HTTP decoded 43.0 KiB 43.0 KiB 0 B (0.0%) 53.7 KiB ✅
Claude fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Claude fleet shell subscribe WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Claude fleet shell resume check rows 0 0 0 0 ✅
Claude stale shell reload HTTP decoded 43.0 KiB 43.0 KiB 0 B (0.0%) 53.7 KiB ✅
Claude stale shell reload rows 27 27 0 (0.0%) 27 ✅
Claude stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Claude stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude stale todo list cold open HTTP decoded 73.4 KiB 73.4 KiB 0 B (0.0%) 83.0 KiB ✅
Claude stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Claude stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅

Baseline: db2cee8 · PR result: 9ba42cc · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@andrewcai8 andrewcai8 added agent-context-increase Accept agent context growth in agentContextBudget.json and removed agent-context-increase Accept agent context growth in agentContextBudget.json labels Nov 19, 2026
@andrewcai8
andrewcai8 merged commit 8a720e0 into main Nov 19, 2026
111 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-context-increase Accept agent context growth in agentContextBudget.json 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:XXL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.