Skip to content

chore: sync upstream through e3949714e3 - #298

Merged
andrewcai8 merged 228 commits into
mainfrom
sync/upstream-e3949714e3
Nov 17, 2026
Merged

andrewcai8 merged 228 commits into
mainfrom
sync/upstream-e3949714e3

Conversation

@andrewcai8

@andrewcai8 andrewcai8 commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Why

Syncs the fork with upstream pingdotgg/t3code through e394971, upstream's newest main with green CI as of 2026-11-17 20:17Z. That is 225 commits on top of the last sync (#294, fecd713). Merge commit; land with a merge, never squash.

What changed

Notable upstream changes:

Conflict resolutions (18 files):

  • Contracts/ws: the fork's CoreWsRpcGroup/CoreServerWsRpcGroup split keeps upstream's issue RPCs, handlers and split prefixes. Both sides' settings additions are kept.
  • MCP: the fork's shared readThreadPage takes upstream's new runCount. FleetService passes its full run count. t3_thread_launch keeps viaFleet and the Home logic, plus upstream's retry-project check, its existing_worktree replay lookup and its worktree default.
  • Orchestration: ProviderTurnStartService keeps the fork's injectHistory guard on uncertain delivery and adds upstream's nativeSessionLacksKeptTurns. RunExecutionService keeps the fork's fall-through, which already holds any non-continuing terminal while the thread probe reports work; it is a superset of upstream's failed-only hold.
  • Tests: upstream's new gateway 429 rows keep the fork's assumed 30-minute reset where no cooldown is readable. ForkMigrations pins 097/098. The agent context budget is 58756, which is the fork's 56347 plus upstream's growth of 2409 (label agent-context-increase).
  • Mobile: the floating status keeps the fork's cloud-wake notice and waking text. Plain reconnecting text moves to upstream's header. The draft's project stamp feeds the fork's environment pick, so a stamp on another chat's box is still steered off. The outbox keeps claimFirstTurnCloudBox and holdQueuedBoxDemand in upstream's fiber rewrite. A connectionStatusLabel that auto-merged twice into ThreadRouteContent was renamed.
  • client-runtime: the fork's box-wake states set upstream's new refusedRouteIds.
  • CI: the fingerprint check keeps the fork's runner and takes upstream's edited-title skip.
  • After the merge: upstream's new i18n catalog check (fix(i18n): catalogs match the source, with a CI check pingdotgg/t3code#37954) needed the fork's "Home" settings label in every catalog (kept as "Home"). The fork-only ClaudeBackgroundWorkAfterLimit.test.ts now expects upstream's runId on background tasks, and it sends the task notification and recorded wake turn a limited CLI really sends. Upstream (fix(server): background tasks survive a failed Claude turn on a live process pingdotgg/t3code#31840) keeps a finished task listed until its result wakes the agent; adapter unchanged.

Blast Radius

New upstream migrations: 097 creates the empty issue_tracker_bindings table, which is instant. 098 builds two partial expression indexes, over active rows of orchestration_v2_projection_threads and over orchestration_v2_projection_provider_threads. The PC has 35,801 active threads and 19,381 provider threads (read-only count). Inferred cost is seconds to well under a minute, since it does not touch turn items. Still, expect a slower first start than a no-migration deploy.

Verification

  • vp run typecheck: contracts, server, client-runtime, mobile, web.
  • vp fmt --check and vp lint on all 768 files that differ from upstream. vp run knip:check.
  • Full vp test run: client-runtime, mobile, contracts. Server: full suite run; the 14 files failing locally fail only on this Mac (tmpdir symlinks, APFS case, Chrome) and pass on CI's 8 server shards. Web: all 34 fork-touched test files (24 unit, 10 browser) plus SidebarDraftBlock.

Not verified locally: the full web and desktop suites (left to CI), and a real-client pass of the mobile connection status and new-task flow.

Follow-ups: FleetService threads.read still loads every run; it could use upstream's limited loading from pingdotgg#37915.

Claude Opus 5.5 did the sync in Claude Code.

🤖 Generated with Claude Code

juliusmarminge and others added 30 commits November 16, 2026 08:49
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… keep uploading (pingdotgg#37681)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Marker-bit <Marker-bit@users.noreply.github.com>
…gdotgg#37703)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: screen <screen@users.noreply.git.cafe>
Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ead (pingdotgg#37735)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#37741)

Co-authored-by: Usama Khan <usama@Usamas-MacBook-Pro.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…heir project (pingdotgg#37682)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…hread (pingdotgg#37725)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… with web (pingdotgg#37743)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…er area (pingdotgg#37508)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…lds (pingdotgg#37755)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…s an error (pingdotgg#37747)

Co-authored-by: Martin Bergo <14320143+mInrOz@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#37745)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
VendettaGhub and others added 21 commits November 17, 2026 09:21
…ingdotgg#38216)

Co-authored-by: Hannes Lenz <hlenz@esic-sarida.cloud>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gdotgg#38235)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…swers (pingdotgg#38237)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…#38238)

Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…me (pingdotgg#38249)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
pingdotgg#38250)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#38276)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…n recovery (pingdotgg#38241)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Merge upstream pingdotgg/t3code through e394971 (225 commits since
fecd713). Conflicts resolved keeping fork behavior: CoreWsRpcGroup
split with issue RPCs, readThreadPage takes runCount, t3_thread_launch
keeps viaFleet and Home logic with upstream's launch changes, mobile
cloud-wake status and box-aware environment pick, outbox box demand in
upstream's fiber rewrite, box-wake states set refusedRouteIds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@andrewcai8 andrewcai8 added the agent-context-increase Accept agent context growth in agentContextBudget.json label Nov 17, 2026
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XXL labels Nov 17, 2026
@github-actions

Copy link
Copy Markdown

This PR changes the test suite by +300 test cases (browser +32, unit +176, server +92).

New browser test files: apps/web/src/components/SavedViewsMenu.browser.test.tsx, apps/web/src/components/files/imageDecode.browser.test.ts, apps/web/src/components/pullRequest/PullRequestReactions.browser.test.tsx, apps/web/src/speech/browserVoiceInput.browser.test.ts.
Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.

Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing.

@github-actions github-actions Bot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Nov 17, 2026
Upstream's new i18n catalog check (pingdotgg#37954) requires every source string in
en.json and each locale. Home names the fork's feature, so it stays Home.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.5 KiB 21.5 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Other scenarios

All 64 scenario measurements match main.

All 64 scenario measurements
Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex short turn resume WebSocket decoded 10.5 KiB 10.5 KiB 0 B (0.0%) 12.7 KiB ✅
Codex short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn running, cold open HTTP decoded 281.7 KiB 281.7 KiB 0 B (0.0%) 302.7 KiB ✅
Codex long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Codex long turn running, history page HTTP decoded 92.4 KiB 92.4 KiB 0 B (0.0%) 107.4 KiB ✅
Codex long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Codex long turn finished, cold open HTTP decoded 381.5 KiB 381.5 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, socket cold open WebSocket decoded 381.6 KiB 381.6 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, work page HTTP decoded 186.2 KiB 186.2 KiB 0 B (0.0%) 200.2 KiB ✅
Codex long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Codex idle thread resume WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell snapshot HTTP decoded 42.4 KiB 42.4 KiB 0 B (0.0%) 53.7 KiB ✅
Codex fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Codex fleet shell subscribe WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Codex fleet shell resume check rows 0 0 0 0 ✅
Codex stale shell reload HTTP decoded 42.4 KiB 42.4 KiB 0 B (0.0%) 53.7 KiB ✅
Codex stale shell reload rows 27 27 0 (0.0%) 27 ✅
Codex stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Codex stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex stale todo list cold open HTTP decoded 72.4 KiB 72.4 KiB 0 B (0.0%) 83.0 KiB ✅
Codex stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Codex stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅
Claude short turn resume WebSocket decoded 10.6 KiB 10.6 KiB 0 B (0.0%) 12.7 KiB ✅
Claude short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn running, cold open HTTP decoded 283.3 KiB 283.3 KiB 0 B (0.0%) 302.7 KiB ✅
Claude long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Claude long turn running, history page HTTP decoded 93.4 KiB 93.4 KiB 0 B (0.0%) 107.4 KiB ✅
Claude long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Claude long turn finished, cold open HTTP decoded 384.2 KiB 384.2 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, socket cold open WebSocket decoded 384.3 KiB 384.3 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, work page HTTP decoded 188.1 KiB 188.1 KiB 0 B (0.0%) 200.2 KiB ✅
Claude long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Claude idle thread resume WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell snapshot HTTP decoded 43.0 KiB 43.0 KiB 0 B (0.0%) 53.7 KiB ✅
Claude fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Claude fleet shell subscribe WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Claude fleet shell resume check rows 0 0 0 0 ✅
Claude stale shell reload HTTP decoded 43.0 KiB 43.0 KiB 0 B (0.0%) 53.7 KiB ✅
Claude stale shell reload rows 27 27 0 (0.0%) 27 ✅
Claude stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Claude stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude stale todo list cold open HTTP decoded 73.4 KiB 73.4 KiB 0 B (0.0%) 83.0 KiB ✅
Claude stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Claude stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅

Baseline: 15a38a0 · PR result: 08bf3df · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

… sends

Upstream now stamps runId on a thread's background tasks (pingdotgg#38035) and keeps
a failed turn's tasks on a live process until their result wakes the agent
(pingdotgg#31840). The fork test expects the runId, and the shell's end now sends the
task notification and the recorded wake turn with the wake worker running,
as production does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@andrewcai8
andrewcai8 merged commit d55234b into main Nov 17, 2026
48 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-context-increase Accept agent context growth in agentContextBudget.json 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:XXL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.