Support impulse triggers via Steam Input#6
Conversation
|
Here is the DLL I've compiled in case anyone wants to try it. |
|
Also, @Kaldaien you may find this interesting. |
|
thanks for the pr, generally the code is pretty good. |
|
ah I don't get those when I build, will TAL |
I don't understand why different things need to be done based on the controller. Doesn't SteamInput abstract controllers and provide the same API for all of them? |
|
It does do that but I'm 99% sure that the left right trigger vibration is ignored on non-compatible controllers, and doing it like this ensures you get at least some effect, previous to how we merged things before with xinput vibration |
|
I'm pretty busy with work right now so if you want to push this ahead and make the changes needed go ahead, I've enabled edits by maintainers so you can push to this branch. I will probably get to this this week otherwise |
|
in the next few days I will fix the warnings and merge the code |
Fixes #4
This PR is not that big it's just due to including all of the Steam API headers.
You may need to make changes on this PR depending on how you're compiling this or differences between my compiling-through-wine-system vs the Windows VM. It shouldn't be too bad though.
Also, first time doing anything with C++ woot lol this language is unbelievably cursed