Repository navigation
Use the Aether artwork as the desktop player icon - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The desktop player's icon was still an open TODO, so its window, tray and installers did not show Aether's artwork. It now uses the same artwork as the SPA favicon, rendered from one source by
make iconsso the two stay in sync.What
make iconsnow also renders the player's icon set intoplayer/src-tauri/icons/withtauri iconfromserver/zarf/icon/web/icon.svg. It drops the unused android/ios sets and64x64.png, and now needsmake player-preparefor the Tauri CLI.default_window_icon().src-tauri/icons/as generated output, and the icon TODO and the "app icon/branding" gap are closed.AGENTS.mdis now the instructions file itself instead of a symlink toCLAUDE.md.CLAUDE.mdis removed (content unchanged), and so is the project-local/verifyskill.Notes
docs/agents/pages still mentionCLAUDE.mdby name. That content now lives inAGENTS.md.