Skip to content

fix(liturgy): alignment arrow recompute from live DOM on hover #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anantham wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(liturgy): alignment arrow recompute from live DOM on hover #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/liturgy/shapes/TripleScriptWitness.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,9 +932,15 @@ const SegmentRow: React.FC<{
// one morpheme's centre, collapsing the auto-distributed fan.
const adjustedLines = (() => {
if (!hovered || !containerRef.current) return lines;
// Recompute lines fresh from current DOM — defensive against a stale
// `lines` cache. The cache can be wrong when computeAlignmentLines
// ran during a transient state (e.g. script swap before Devanāgarī
// fonts loaded), giving zero-size element rects and negative-space
// coordinates. We're hovering now, so the DOM is settled.
const fresh = computeAlignmentLines(containerRef.current, currentWitness?.alignTo);
const cRect = containerRef.current.getBoundingClientRect();
const r = hovered.element.getBoundingClientRect();
return lines.map((l) => {
return fresh.map((l) => {
if (
hovered.kind === 'pali' &&
l.paliIdx === hovered.idx &&
Expand Down
Loading