Repository navigation
feat: an MMS switch that leaves only text messaging - #514
Merged
Merged
Conversation
Settings → Advanced → MMS check now opens with a switch. Off, the app sends text and nothing else. - The composer loses the plus and the tray behind it (camera, gallery, audio, location, contact) and the microphone, because a voice note is an MMS attachment like any other. - The emoji button takes the slot the plus held, and turning MMS off turns the emoji setting on so the bar is not left with a hole. - Every media send path refuses with an explanation instead of failing silently: the composer, the share sheet, and a retry of a failed media message. - A group text no longer goes out as one MMS while the switch is off; it falls back to the per-person SMS path that already exists for carriers that forbid group MMS. - Incoming MMS is still received and shown: the setting is about what this phone sends, and throwing away a picture someone sent would be worse. JUnit: MmsDisabledComposerTest (the setting and its default, the composer flags, the emoji slot, every refused send path, the group fallback, the switch on the MMS page). scripts/test-mms-disabled.sh: 5 checks on emulator-5556, 0 failed — no plus with MMS off, the emoji button in the plus's slot, the plus back with MMS on. The same run fails both MMS-off checks on the previous build. New strings: settings_mms_enabled, settings_mms_enabled_summary, chat_mms_disabled (all 13 locales; "MMS" stays untranslated, like SMS).
The switch was a card of its own above the per-SIM checks, which reads as two unrelated things: same question, two panels. Both now sit in one GroupedRowList split by hairlines — the switch, then each carrier. SettingsRow draws every row as its own card by design (its positions only soften the corners of a gap-separated run), so the row here is a small grouped-content row instead, with the switch as its trailing control. JUnit: the card test now holds the switch and the carriers to one list. Preview added for the row so PreviewCoverageTest stays green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Settings -> Advanced -> MMS check now opens with an MMS switch. Off, the app sends text and nothing else.
Why
Requested: a way to turn MMS off completely, with the emoji button taking the plus's place.
Testing
./gradlew testDebugUnitTestpassesMmsDisabledComposerTest(the setting and its default, the composer flags, the emoji slot, every refused send path, the group fallback, the switch on the MMS page).scripts/test-mms-disabled.sh: 5 passed, 0 failed onemulator-5556On the previous build the same run fails both MMS-off checks (the plus is still there and the emoji button is at the far end).
Related issue
None - requested directly.
New strings:
settings_mms_enabled,settings_mms_enabled_summary,chat_mms_disabled(all 13 locales; "MMS" stays untranslated, like SMS).