Skip to content

feat: an MMS switch that leaves only text messaging - #514

Merged
an1ndra merged 2 commits into
Developfrom
feat/disable-mms
Nov 19, 2026
Merged

an1ndra merged 2 commits into
Developfrom
feat/disable-mms

Conversation

@an1ndra

@an1ndra an1ndra commented Nov 19, 2026

Copy link
Copy Markdown
Owner

What changed

Settings -> Advanced -> MMS check now opens with an MMS switch. Off, the app sends text and nothing else.

  • The composer loses the plus and the tray behind it (camera, gallery, audio, location, contact) and the microphone, because a voice note is an MMS attachment like any other.
  • The emoji button takes the plus's slot, and turning MMS off turns the emoji setting on so the bar is not left with a hole.
  • Every media send path refuses with an explanation instead of failing silently: the composer, the share sheet, and a retry of a failed media message.
  • A group text no longer goes out as one MMS while the switch is off; it falls back to the per-person SMS path that already exists for carriers that forbid group MMS.
  • Incoming MMS is still received and shown - the setting is about what this phone sends, and throwing away a picture someone sent would be worse.

Why

Requested: a way to turn MMS off completely, with the emoji button taking the plus's place.

Testing

  • ./gradlew testDebugUnitTest passes
  • JUnit test added: MmsDisabledComposerTest (the setting and its default, the composer flags, the emoji slot, every refused send path, the group fallback, the switch on the MMS page).
  • scripts/test-mms-disabled.sh: 5 passed, 0 failed on emulator-5556
[PASS] no 'Attach' button with MMS off
[PASS] the 'Emoji' button is in the composer
[PASS] it sits where the plus was, at the start of the bar (96px)
[PASS] the 'Attach' button is back

On the previous build the same run fails both MMS-off checks (the plus is still there and the emoji button is at the far end).

Related issue

None - requested directly.

New strings: settings_mms_enabled, settings_mms_enabled_summary, chat_mms_disabled (all 13 locales; "MMS" stays untranslated, like SMS).

Settings → Advanced → MMS check now opens with a switch. Off, the app
sends text and nothing else.

- The composer loses the plus and the tray behind it (camera, gallery,
  audio, location, contact) and the microphone, because a voice note is
  an MMS attachment like any other.
- The emoji button takes the slot the plus held, and turning MMS off turns
  the emoji setting on so the bar is not left with a hole.
- Every media send path refuses with an explanation instead of failing
  silently: the composer, the share sheet, and a retry of a failed media
  message.
- A group text no longer goes out as one MMS while the switch is off; it
  falls back to the per-person SMS path that already exists for carriers
  that forbid group MMS.
- Incoming MMS is still received and shown: the setting is about what this
  phone sends, and throwing away a picture someone sent would be worse.

JUnit: MmsDisabledComposerTest (the setting and its default, the composer
flags, the emoji slot, every refused send path, the group fallback, the
switch on the MMS page).

scripts/test-mms-disabled.sh: 5 checks on emulator-5556, 0 failed — no
plus with MMS off, the emoji button in the plus's slot, the plus back with
MMS on. The same run fails both MMS-off checks on the previous build.

New strings: settings_mms_enabled, settings_mms_enabled_summary,
chat_mms_disabled (all 13 locales; "MMS" stays untranslated, like SMS).
The switch was a card of its own above the per-SIM checks, which reads as
two unrelated things: same question, two panels. Both now sit in one
GroupedRowList split by hairlines — the switch, then each carrier.

SettingsRow draws every row as its own card by design (its positions only
soften the corners of a gap-separated run), so the row here is a small
grouped-content row instead, with the switch as its trailing control.

JUnit: the card test now holds the switch and the carriers to one list.
Preview added for the row so PreviewCoverageTest stays green.
@an1ndra
an1ndra merged commit 2ddc96e into Develop Nov 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant