Repository navigation
feat: the inbox gets a back-to-top shortcut - #511
Merged
Merged
Conversation
Scrolling a long inbox back to the top meant flicking through every row again. Past eight rows out of sight, a small round button appears in the middle of the bottom edge with an up chevron; tapping it animates the list back to the top, where the button disappears again. - It sits in the middle of the bottom edge, at 70% opacity: it floats over the rows, and at full strength the disc read as a hole punched through the list. The start-chat button keeps its corner. - Drawn as a Surface rather than a floating-action-button: the FAB's own container added a corner shape and a minimum touch target around the content, which drew a square edge around a round button. - It is hidden on the archived view, and while the list is at the top. JUnit: BackToTopTest (the eight-row threshold either side, and the 70% alpha the design asks for) and a preview so PreviewCoverageTest stays green. scripts/test-back-to-top.sh: 6 checks on emulator-5556, 0 failed — no button at the top, one after three screens, centred on the bottom edge, and the list back at its first row after a tap. The same run fails on the previous build, which has no button at all. The new label is in all 13 locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Scrolling a long inbox back to the top meant flicking through every row again. Past eight rows out of sight, a small round shortcut appears in the middle of the bottom edge; tapping it animates the list back to the top, where it disappears again.
Why
Scrolled far down, the top is a chore to reach; a shortcut is worth one small disc once it is. Two design notes came from review: bottom-centre placement, and 70% opacity.
Testing
./gradlew testDebugUnitTestpassesapp/src/test/java/(BackToTopTest: the threshold either side, the 0.7 alpha)scripts/test-*.shadded, and it fails before the fix / passes afterscripts/test-back-to-top.shonemulator-5556— 6 passed, 0 failed:On the previous build it fails at the top of the run — there is no button and no label for it.
Measured on the emulator: bounds
[479,2097][605,2223], centre x = 542 against a 540 px screen centre, and the screenshot shows a circular, 70%-transparent disc with the up chevron, with the row behind it legible through it.Related issue
None — requested directly.
New string:
conversations_back_to_top(all 13 locales).