Skip to content

fix: a phone must not paint an opaque surface over the inbox - #504

Merged
an1ndra merged 1 commit into
Developfrom
fix/inbox-overlay
Nov 19, 2026
Merged

an1ndra merged 1 commit into
Developfrom
fix/inbox-overlay

Conversation

@an1ndra

@an1ndra an1ndra commented Nov 19, 2026

Copy link
Copy Markdown
Owner

What was wrong

The two-pane change (#501) gave the route stack's "list" pane a surface background, so that a split window shows an empty-state card beside the conversation list:

if (target == "list") {
    Box(Modifier.fillMaxSize().background(MaterialTheme.colorScheme.surface), Center) {
        if (twoPaneLayout) { Text(stringResource(R.string.two_pane_empty)) }
    }
}

On a phone the conversation list is drawn underneath that stack, so the opaque surface covered the entire inbox. The list was still composed, scrollable and clickable — accessibility and uiautomator see every row — but the screen was black. Settings and every other screen painted normally, which is why it looked like a blank app rather than a broken one.

Reproduced on the reporting phone (Android 16, 3,162 threads): screencap returned a black frame while the semantics tree held conversations=3162 displayed=3162.

The fix

if (target == "list") {
    if (twoPaneLayout) {
        Box(Modifier.fillMaxSize().background(...), Center) { Text(stringResource(R.string.two_pane_empty)) }
    } else {
        Box(Modifier.fillMaxSize())     // transparent, as it was before the split
    }
}

A phone gets the transparent pane again; only a genuinely split window owns that column and draws the card.

Proof

Before / after on the reporting phone, same database, same launch path:

  • before: screenshot completely black; InboxDiag: conversations=3162 displayed=3162 … loaded=true; Settings screen painted fine.
  • after: screenshot shows the inbox — CRED, Zepto OTP, Bigbasket, Kotak, HDFC rows with avatars, snippets and timestamps; Start chat button visible.

JUnit ListPaneTransparencyTest — the opaque pane and its empty-state card exist only inside if (twoPaneLayout), and the phone branch is a plain transparent Box. TwoPaneLayoutTest updated for the new nesting.

Supersedes the black-screen part of #503 (which fixed a separate, real regression: the skeleton was skipped while a re-import ran, because first_import_done is persisted).

The two-pane change gave the route stack's "list" pane a surface background so
that a split window shows an empty-state card beside the list. On a phone the
conversation list is drawn underneath that stack, so the surface covered the
whole inbox: the list was composed, scrollable and clickable, but the screen was
black — while every other screen, Settings included, painted normally.

The background and the empty-state text now exist only when the window really
is split; a phone gets the transparent pane it had before.
@an1ndra
an1ndra merged commit ef034d8 into Develop Nov 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant