Repository navigation
fix: a phone must not paint an opaque surface over the inbox - #504
Merged
Merged
Conversation
The two-pane change gave the route stack's "list" pane a surface background so that a split window shows an empty-state card beside the list. On a phone the conversation list is drawn underneath that stack, so the surface covered the whole inbox: the list was composed, scrollable and clickable, but the screen was black — while every other screen, Settings included, painted normally. The background and the empty-state text now exist only when the window really is split; a phone gets the transparent pane it had before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The two-pane change (#501) gave the route stack's
"list"pane a surface background, so that a split window shows an empty-state card beside the conversation list:On a phone the conversation list is drawn underneath that stack, so the opaque surface covered the entire inbox. The list was still composed, scrollable and clickable — accessibility and
uiautomatorsee every row — but the screen was black. Settings and every other screen painted normally, which is why it looked like a blank app rather than a broken one.Reproduced on the reporting phone (Android 16, 3,162 threads):
screencapreturned a black frame while the semantics tree heldconversations=3162 displayed=3162.The fix
A phone gets the transparent pane again; only a genuinely split window owns that column and draws the card.
Proof
Before / after on the reporting phone, same database, same launch path:
InboxDiag: conversations=3162 displayed=3162 … loaded=true; Settings screen painted fine.Start chatbutton visible.JUnit
ListPaneTransparencyTest— the opaque pane and its empty-state card exist only insideif (twoPaneLayout), and the phone branch is a plain transparentBox.TwoPaneLayoutTestupdated for the new nesting.Supersedes the black-screen part of #503 (which fixed a separate, real regression: the skeleton was skipped while a re-import ran, because
first_import_doneis persisted).