Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Make whitespace match PSR/2 standard (3.2.0 update)#63

Open
ejegg wants to merge 1 commit into
amzn:masterfrom
ejegg:3.2.0-ws
Open

Make whitespace match PSR/2 standard (3.2.0 update)#63
ejegg wants to merge 1 commit into
amzn:masterfrom
ejegg:3.2.0-ws

Conversation

@ejegg

@ejegg ejegg commented Dec 15, 2017

Copy link
Copy Markdown

This is the recommended standard for PHP libraries

Also inserts missing braces around one-line conditionals and standardizes case of booleans.

@ejegg

ejegg commented Dec 15, 2017

Copy link
Copy Markdown
Author

@bjguillot , to review this you might want to use the '-w' switch to 'git diff' or 'git log'

That switch will ignore all the changes where whitespace is just inserted or deleted within a single line, and show all the place where braces have been moved to different lines, etc.

This was referenced Dec 15, 2017
@ejegg

ejegg commented Dec 15, 2017

Copy link
Copy Markdown
Author

Fixes #34

@bjguillot

Copy link
Copy Markdown
Contributor

Thanks for the suggestion on the '-w' switch.

@ejegg ejegg force-pushed the 3.2.0-ws branch 3 times, most recently from 2a9fe1b to 2bd2018 Compare January 11, 2018 23:23
To make future diffs cleaner.
Also inserts explicit braces around oneline if statements.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants