fix(shell-hook): pass the cd target through a file so prompts keep the TTY - #42
Open
amustafa wants to merge 1 commit into
Open
fix(shell-hook): pass the cd target through a file so prompts keep the TTY#42amustafa wants to merge 1 commit into
amustafa wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
amustafa
force-pushed
the
am/shell-hook-cd-file
branch
from
August 18, 2026 18:34
009ac14 to
34e9a12
Compare
amustafa
force-pushed
the
am/shell-hook-cd-file
branch
from
August 19, 2026 14:56
34e9a12 to
0d57b0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The shell hook no longer captures
sr's stdout. The cd target for worktree navigation now travels through a scratch file (SR_CD_FILE) instead of a__sr_cd:sentinel parsed out of captured output.Why
The old hook ran
output="$(command sr "$@")". Command substitution turns stdout into a pipe, root's TTY check then classifies the run as non-interactive, and every interactive prompt (submit's PR creation, preflight decisions, navigation choices) silently takes its scripted branch. In other words: installing the hook — the documented setup step — disabled half the CLI.How
SR_CD_FILE, and runssrwith stdin/stdout attached to the terminal. Afterwards it reads the cd target from the file, cds, and cleans up.handleNavigateResultwrites the target intoSR_CD_FILEwhen set; the__sr_cd:stdout sentinel remains as the fallback for hooks eval'd before this change (and when the file write fails).mktempfails, the hook degrades to runningsrdirectly with no cd.🤖 Generated with Claude Code