Fix release workflow: checkout submodules for wheel and sdist builds#434
Merged
zihaowang678 merged 1 commit intoJun 5, 2026
Merged
Conversation
The build-wheels and source-distribution jobs used actions/checkout without submodules, so src/ion-c/ was empty and CMake failed with "does not contain a CMakeLists.txt file". Also remove the PyPI verification step from source-distribution — it tried to pip install from PyPI before anything was published there (upload-wheels runs later), so it always failed.
tgregg
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build-wheels and source-distribution jobs used actions/checkout without submodules, so src/ion-c/ was empty and CMake failed with "does not contain a CMakeLists.txt file".
Also remove the PyPI verification step from source-distribution — it tried to pip install from PyPI before anything was published there (upload-wheels runs later), so it always failed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.