Repository navigation
Meet AA contrast on the site, and answer its quiz from the keyboard - #25
Merged
Merged
Conversation
Lighthouse flagged the light theme's orange (3.9:1 on white) and three of highlight.js's GitHub colours (down to 3.3:1); the dark theme's white text on orange buttons was 2.5:1 and went unflagged only because Lighthouse runs in light mode. Accessibility is now 100 in both themes on the front page, a question page and the quiz. - Letters or digits pick an option, Enter checks and then moves on, S skips, as in the terminal quiz. - Search matches every word in any order instead of the exact phrase. - 404.html offers to search for the words in the missing address, and ?search= opens the site with a query filled in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrast (WCAG AA) in both themes. Lighthouse flagged the light orange (3.9:1 on white, 3.5:1 on the selected tab) and highlight.js's GitHub keyword, built-in and tag colours (down to 3.3:1). In dark mode the white text on orange buttons was 2.5:1; Lighthouse missed it because it only runs light. Now: orange
#b54708(5.4:1), dark text on dark-mode buttons (7.5:1), GitHub's current darker code colours. Lighthouse accessibility: 100 on the front page, a question page and the quiz, in light and in dark.Keyboard quiz:
a-hor1-8pick an option,Enterchecks and then goes on,sskips. Option letters are shown, with a hint line (hidden on touch screens). Typing in the search box is left alone.Search matches all words in any order instead of the exact phrase.
404.html: offers to search for the words in the missing address (/q/volatile-arrays/becomes a search for "volatile arrays");?search=fills the search box../gradlew testpassesBuilt with
tools/site, checked in Chrome: keyboard answering, dark mode, search, 404