Repository navigation
fix: stop logging our own teardown as a receive failure - #11
Merged
RobertPoienar merged 1 commit intoAug 13, 2026
Merged
RobertPoienar merged 1 commit into
RobertPoienar merged 1 commit into
Conversation
A client whose network dropped is still TCP-connected but will never answer the close handshake. The server writes its close frame, waits out _waitTime for a reply that never arrives, then disposes the transport in releaseServerResources() while the receive loop is still parked in a read. That read then failed with [Fatal] Cannot access a disposed object. Object name: 'System.Net.Sockets.NetworkStream'. once per socket of the departing client, and aborted a connection that was already closing - reported on AltTester-Server issue sta#181 after the connect-time fix landed, where an Android app losing its network logged the pair for its command and live-update legs. Once closing has begun, a failed read is the expected result of our own teardown, so report receiving as finished and trace it instead. Reads that fail while the connection is still Open keep the Fatal and the abort, which is where they mean something.
RobertPoienar
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client whose network dropped is still TCP-connected but will never answer the close handshake. The server writes its close frame, waits out _waitTime for a reply that never arrives, then disposes the transport in releaseServerResources() while the receive loop is still parked in a read. That read then failed with
[Fatal] Cannot access a disposed object.
Object name: 'System.Net.Sockets.NetworkStream'.
once per socket of the departing client, and aborted a connection that was already closing - reported on AltTester-Server issue sta#181 after the connect-time fix landed, where an Android app losing its network logged the pair for its command and live-update legs.
Once closing has begun, a failed read is the expected result of our own teardown, so report receiving as finished and trace it instead. Reads that fail while the connection is still Open keep the Fatal and the abort, which is where they mean something.