Repository navigation
ci: build altserverwebsocket-sharp.dll and upload it as an artifact - #10
Merged
Merged
Conversation
AltTester-Server vendors this DLL rather than consuming a package, and the binary was produced by hand, so it drifted from the source: the copy that shipped carried an unmerged fix (the Stop() deadlock work) while missing a merged one (the ReadBytesAsync stack-overflow guard), matching no branch in this repository. Build it on push and pull request against AltServer-Websocket-Sharp, and on demand, uploading all three target frameworks. netstandard2.0 is the one AltTester-Server vendors today. Builds the project file directly: the solution still refers to the pre-rename websocket-sharp.csproj and no longer loads.
Match AltTester-Server, whose tests job runs on [self-hosted, Windows] and relies on the SDK already being installed there, so drop setup-dotnet rather than reinstalling a toolchain on a shared machine. Carry over the guards that go with running on our own hardware: skip drafts, and skip pull requests from forks. This repository is a public fork, so without the second guard anyone's pull request would execute on the runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AltTester-Server vendors this DLL rather than consuming a package, and the binary was produced by hand, so it drifted from the source: the copy that shipped carried an unmerged fix (the Stop() deadlock work) while missing a merged one (the ReadBytesAsync stack-overflow guard), matching no branch in this repository.
Build it on push and pull request against AltServer-Websocket-Sharp, and on demand, uploading all three target frameworks. netstandard2.0 is the one AltTester-Server vendors today.
Builds the project file directly: the solution still refers to the pre-rename websocket-sharp.csproj and no longer loads.