Skip to content

ci: build altserverwebsocket-sharp.dll and upload it as an artifact - #10

Merged
andreion1ca merged 2 commits into
AltServer-Websocket-Sharpfrom
ci/build-server-dll
Aug 10, 2026
Merged

andreion1ca merged 2 commits into
AltServer-Websocket-Sharpfrom
ci/build-server-dll

Conversation

@andreion1ca

Copy link
Copy Markdown

AltTester-Server vendors this DLL rather than consuming a package, and the binary was produced by hand, so it drifted from the source: the copy that shipped carried an unmerged fix (the Stop() deadlock work) while missing a merged one (the ReadBytesAsync stack-overflow guard), matching no branch in this repository.

Build it on push and pull request against AltServer-Websocket-Sharp, and on demand, uploading all three target frameworks. netstandard2.0 is the one AltTester-Server vendors today.

Builds the project file directly: the solution still refers to the pre-rename websocket-sharp.csproj and no longer loads.

AltTester-Server vendors this DLL rather than consuming a package, and the
binary was produced by hand, so it drifted from the source: the copy that
shipped carried an unmerged fix (the Stop() deadlock work) while missing a
merged one (the ReadBytesAsync stack-overflow guard), matching no branch in
this repository.

Build it on push and pull request against AltServer-Websocket-Sharp, and on
demand, uploading all three target frameworks. netstandard2.0 is the one
AltTester-Server vendors today.

Builds the project file directly: the solution still refers to the
pre-rename websocket-sharp.csproj and no longer loads.
Match AltTester-Server, whose tests job runs on [self-hosted, Windows] and
relies on the SDK already being installed there, so drop setup-dotnet
rather than reinstalling a toolchain on a shared machine.

Carry over the guards that go with running on our own hardware: skip
drafts, and skip pull requests from forks. This repository is a public
fork, so without the second guard anyone's pull request would execute on
the runner.
@andreion1ca
andreion1ca merged commit 05ddac7 into AltServer-Websocket-Sharp Aug 10, 2026
1 check passed
@andreion1ca
andreion1ca deleted the ci/build-server-dll branch August 10, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant