generate_sms_delivery_stats: record results in new otel metric #4911
Open
risicle wants to merge 2 commits into
Open
generate_sms_delivery_stats: record results in new otel metric #4911risicle wants to merge 2 commits into
generate_sms_delivery_stats: record results in new otel metric #4911risicle wants to merge 2 commits into
Conversation
risicle
changed the title
generate_sms_delivery_stats: record results in new otel metric
as reflected in the description, this is an imperfect measure but it most closely reflects the current sms balancer algorithm's view of the world. this replaces a similar metric that was recorded here but got removed with all rest of the statsd stuff
risicle
force-pushed
the
ris-sms-delivery-stats-restore-metric
branch
from
e5f900d to
0cf69f5
Compare
robinjam
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reflected in the metric's
description, this is an imperfect measure but it most closely reflects the current sms balancer algorithm's view of the world.This replaces a similar metric that was recorded here but got removed with all rest of the statsd stuff.
Because we don't know which instance this celery job is going to run on, this metric will need some promql magic to make it appear as a single continuous metric.
Depends on https://github.com/alphagov/notifications-aws/pull/3042 to work properly.