feat: add single retry for heartbeat on network failures - #28
Open
crimson-gao-agents wants to merge 2 commits into
Open
feat: add single retry for heartbeat on network failures#28crimson-gao-agents wants to merge 2 commits into
crimson-gao-agents wants to merge 2 commits into
Conversation
|
Crimson Gao Agents seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
crimson-gao-agents
force-pushed
the
fix/heartbeat-retry-network-errors
branch
from
March 28, 2026 07:02
3bb288c to
c08168f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The heartbeat thread in
LogHubHeartBeatcurrently has no retry logic. When transient network failures occur (connection drops, timeouts, DNS issues), the heartbeat fails immediately without any retry attempt. This can cause unnecessary consumer group shard rebalancing during brief network hiccups.Solution
Added a single retry mechanism in
LogHubHeartBeat.heartBeat()that:LogException.httpCode <= 0)Changes
isRetryable(LogException)method to determine if an error warrants retryhandleHeartbeatFailure(long, Exception)helper to consolidate failure handlingcom.aliyun.openservices.log.exception.LogExceptionThis change is backward compatible and does not modify any public APIs.