HOTFIX: Move corepack enable before setup node#147
Merged
Conversation
AdamJHall
requested review from
TheOrangePuff,
aaronmedina-dev,
aligent-lturner and
crispy101
aligent-lturner
left a comment
aligent-lturner
left a comment
There was a problem hiding this comment.
Do we need to do the whole "setup node without a cache, corepack enable, setup node with a cache" dance for safety?
TheOrangePuff
approved these changes
May 7, 2026
Contributor
Author
I don't think so, by enabling corepack it should just give the node setup action what it needs to continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
The adobe mesh deploy is failing as it is trying to setup the yarn cache during the setup-node action and failing as corepack has not been enabled yet.
Notes to reviewers
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback