Homebrew Adopt fixed with version-based cask handling#582
Open
boardslayer wants to merge 1 commit into
Open
Conversation
Cache the Homebrew version and provide helpers to determine if --no-quarantine should be used. Build quarantine args dynamically via caskQuarantineArguments() and apply at call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PearCleaner cannot adopt packages in the GUI using Homebrew. The flag was --no-quarantine option was removed in Homebrew 4.7.0.
I've added a version check to see if the currently installed homebrew version is above 4.7.0 or below, to determine whether --no-quarantine should be used. The argument is dynamically added via caskQuarantineArguments() and applied at call sites.