Fix slow app scan on macOS 26 caused by implicit lstat in URL.appendi…#574
Open
RayaCoo wants to merge 1 commit into
Open
Fix slow app scan on macOS 26 caused by implicit lstat in URL.appendi…#574RayaCoo wants to merge 1 commit into
RayaCoo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
App scan stalls 30+ seconds at
Scanning N system locations...on macOS 26. Sample shows 100% of CPU inlstat, called implicitly byURL.appendingPathComponent:appendingPathComponent(_:)(without an explicitisDirectoryargument) consults the filesystem to decide whether to treat the result as a directory — this behavior is documented but easy to miss. Theproposal author noted it when
DirectoryHintwas introduced:AppPathFinder.processLocationandReversePathsSearcher.processLocationcall this on every directory entry inside their inner scan loops. With ~5000 entries across~/Library/Containers, ApplicationSupport, Caches, etc., the redundant
lstats dominate scan time — and the immediately-followingfileExists(atPath:isDirectory:)does the real directory check anyway.Fix
Replace
.appendingPathComponent(x)with.appending(path: x, directoryHint: .notDirectory)at the four hot-loop call sites..notDirectoryonly affects the URL string (trailing slash); downstreamfileExists(atPath:isDirectory:)is authoritative. Behavior unchanged.Scans that previously took 30+ seconds complete in ~1 second on macOS 26.4.1.