feat: relax name validation and harden recovery - #756
Merged
Merged
Conversation
zhourrr
requested review from
Cuiyus,
chinaux and
feihongxu0824
as code owners
September 15, 2026 11:32
zhourrr
force-pushed
the
feat/relax_validation
branch
from
September 16, 2026 05:53
e9aa1b8 to
58547ff
Compare
JalinWang
reviewed
Sep 16, 2026
…rdlink test on Android
zhourrr
force-pushed
the
feat/relax_validation
branch
from
September 16, 2026 14:41
cf55d83 to
ccf6250
Compare
JalinWang
previously approved these changes
Sep 17, 2026
JalinWang
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax document ID and collection name rules with centralized validation and clearer errors.
Fix related WAL recovery, schema, decoding, and Python/C binding issues while preserving storage formats.
Fixes #395
Validation Rules
The new rules are written as below, please review this first.
_!@#$%+=.-_, and-_, and-_zvec_row_id_,_zvec_g_doc_id_,_zvec_uid_,_zvec_score, and_zvec_group_idIdentifier Validation Performance
Summary
For valid ASCII inputs accepted by both implementations, the new validators were approximately 30–63× faster than the previous
std::regexchecks in this microbenchmark.Valid Inputs Accepted by Both Implementations
Newly Supported Inputs
These inputs were rejected by the previous implementation. Only the new validation cost is reported, since the two implementations perform different work.