fix(vamana): honor asymmetric query metrics - #635
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes Vamana streamer behavior for asymmetric metrics by ensuring build-time (add) distance functions and query-time (search) distance functions can differ, so searches honor the metric’s query_metric() when provided.
Changes:
- Cache separate distance/batch-distance callables for add vs search in
VamanaStreamer::open(). - Update
VamanaContext/VamanaDistCalculatorto allow swapping distance implementations per operation. - Add a regression test validating that brute-force and graph search use the asymmetric query metric while add/build uses the base metric.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/core/algorithm/vamana/vamana_streamer_test.cc | Adds regression test covering asymmetric query metric behavior across add, BF search, graph search, and BF-by-primary-keys search. |
| src/core/algorithm/vamana/vamana_streamer.h | Introduces cached add/search distance and batch-distance function members. |
| src/core/algorithm/vamana/vamana_streamer.cc | Initializes add/search distance callables in open() and applies them to contexts in add/search code paths. |
| src/core/algorithm/vamana/vamana_dist_calculator.h | Adds a method to update the distance and batch-distance callables dynamically. |
| src/core/algorithm/vamana/vamana_context.h | Exposes a context-level helper to update the underlying distance calculator’s callables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.