fix(c-api): stop reporting bogus 0.2.1 version when git tags are missing - #629
Open
chinaux wants to merge 1 commit into
Open
fix(c-api): stop reporting bogus 0.2.1 version when git tags are missing#629chinaux wants to merge 1 commit into
chinaux wants to merge 1 commit into
Conversation
When 'git describe' cannot produce a vX.Y.Z tag (shallow clones, tarball builds), the C API version headers were silently baked with a plausible-looking 0.2.1, lying about the ABI identity. Following DuckDB's approach: add OVERRIDE_GIT_DESCRIBE cache variable so packagers/CI can inject an explicit version (with format validation, FATAL_ERROR on malformed input), and fall back to an obviously-dummy v0.0.0 with a loud warning, keeping the commit hash for traceability. Fixes alibaba#621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When 'git describe' cannot produce a vX.Y.Z tag (shallow clones, tarball builds), the C API version headers were silently baked with a plausible-looking 0.2.1, lying about the ABI identity. Following DuckDB's approach: add OVERRIDE_GIT_DESCRIBE cache variable so packagers/CI can inject an explicit version (with format validation, FATAL_ERROR on malformed input), and fall back to an obviously-dummy v0.0.0 with a loud warning, keeping the commit hash for traceability. Fixes #621