Skip to content

feat: support ivf rabitq - #540

Open
egolearner wants to merge 4 commits into
alibaba:mainfrom
egolearner:feat/ivf-rabitq
Open

feat: support ivf rabitq#540
egolearner wants to merge 4 commits into
alibaba:mainfrom
egolearner:feat/ivf-rabitq

Conversation

@egolearner

Copy link
Copy Markdown
Collaborator

No description provided.

@egolearner
egolearner marked this pull request as draft June 30, 2026 06:38
@egolearner
egolearner marked this pull request as ready for review July 1, 2026 05:49
@egolearner
egolearner force-pushed the feat/ivf-rabitq branch 2 times, most recently from a293c44 to b9913b6 Compare July 2, 2026 04:25
@egolearner
egolearner requested a review from feihongxu0824 as a code owner July 2, 2026 04:25
@egolearner
egolearner force-pushed the feat/ivf-rabitq branch 2 times, most recently from 07576fa to e157938 Compare July 3, 2026 09:06
Add the core IVF RaBitQ builder, streamer, entity, reformer, on-disk format, and index provider flow.

Wire IVF_RABITQ through DB schema validation, proto conversion, collection optimization, C API, and Python bindings.

Cover streamer behavior, collection optimize/query paths, parameter serialization, schema validation, proto conversion, and C API usage with tests.
@iaojnh

iaojnh commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

测过optimize吗?感觉reducer针对ivf rabitq可能需要额外的开发

@JalinWang JalinWang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

return ret;
}

// Use context heap for online distk-gated pruning

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo: dist?

@JalinWang

Copy link
Copy Markdown
Collaborator

测过optimize吗?感觉reducer针对ivf rabitq可能需要额外的开发

segment_helper层有针对hnsw_rabitQ的判断,ivf rabitQ应该复用了。

倒是可以考虑添加个SegmentCompactReuseTest的ivf rabitQ实例化case,监测了optimize后的recall,之前hnsw_rabitQ的bug就是靠这个fixture抓出来的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants