feat(session): persist retry reports in session end - #1083
Open
Gongyl01 wants to merge 1 commit into
Open
Conversation
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 6 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Retry reports are currently available only in the CLI output. They are frozen after
Agent.Runreturns, butsession_endis written insideAgent.Run, so the report is unavailable when the session is finalized.This PR persists the existing retry report in
session_end.llm_retry_report:RetryCollectorto the review agent;SessionHistoryand embeds it insession_end;Freezeand output path unchanged;llm_retry_reportfor clean runs with nothing to report;RetryCollector.Freezeremains a deterministic read. The agent and CLI take independent snapshots with the same run ID, and tests verify that their serialized values are equal.Type of Change
How Has This Been Tested?
make testpasses locallyAdditional verification:
make checksession_endRunerrors or agent warningsChecklist
go fmt,go vet)