Guard MetricNode.fromThinString against lines with fewer than 7 fields#3630
Open
vasiliy-mikhailov wants to merge 1 commit into
Open
Guard MetricNode.fromThinString against lines with fewer than 7 fields#3630vasiliy-mikhailov wants to merge 1 commit into
vasiliy-mikhailov wants to merge 1 commit into
Conversation
fromThinString accessed strs[0] through strs[6] unconditionally, so a line with fewer than seven pipe-separated fields threw ArrayIndexOutOfBoundsException. The optional trailing fields (strs[7], strs[8], ...) were already guarded with length checks; apply the same guard to the leading fields so a short or truncated metric line is parsed defensively instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MetricNode.fromThinStringsplits the line on|and then readsstrs[0]throughstrs[6]unconditionally:A line with fewer than seven fields (a short or truncated metric line) throws
ArrayIndexOutOfBoundsException, even though the optional trailing fields are already protected with length checks.Fix
Apply the same length guard to the leading fields, so a short line is parsed defensively (populating the fields that are present) instead of crashing — consistent with the existing handling of
strs[7]/strs[8].Test
Adds
testFromThinStringShortInputtoMetricNodeTestwith a 3-field line. It fails on1.8(ArrayIndexOutOfBoundsException: Index 3 out of bounds for length 3) and passes with this change.AI assistance disclosure
This contribution was produced with the help of an AI pipeline. The pipeline processed a large amount of source code to surface suspected bugs, reproduced a subset of them with failing unit tests and generated candidate fixes, and prepared pull requests from the ones that held up. Each PR was then reviewed and verified by a human before being opened: the fix and test were checked by hand and the test was confirmed to fail before the change and pass after.