chore(egress): reduce outbound log#964
Open
Pangjiping wants to merge 2 commits into
Open
Conversation
Drop duplicate Warn at dnsproxy forward-error path; error already surfaces via the structured `egress.outbound` event field. Dedup periodic always-rules reload Info by fingerprinting the merged deny+allow rule set (fnv64a over sorted action|target keys, with a separator byte between deny and allow to avoid cross-set collisions). Log only when the fingerprint changes vs the last applied set, and include the fingerprint in the message for audit cross-checks. Adds unit tests for fingerprintRules covering order-independence, deny/allow set separation, add/remove detection, action flips, and empty-slice stability. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Reads /var/egress/rules/log_skip.always once at startup. Each line is either an exact domain (foo.com) or a wildcard subdomain pattern (*.foo.com); blank lines and `#` comments are ignored, IP/CIDR entries are rejected. The proxy stores the compiled set under an atomic pointer so the per-query check stays lock-free, and only the success path of serveDNS consults it — error lookups still log so audit is unaffected. The set is one-shot: hot reload is intentionally not wired because this list targets stable infra hostnames (cluster DNS, cloud metadata) that don't churn at runtime. Includes DomainSet wrapper around the existing compiledDomainIndex (case-insensitive, trailing-dot tolerant) and unit coverage for the matcher, the file parser, and the proxy skip plumbing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Breaking Changes
Checklist