Skip to content

Format of crop_size #6

Description

@dfrumkin

Is crop_size in the [height, width] format or [width, height]?

Here it's [height, width]:
https://github.com/alibaba/ClickSEG/blob/main/models/strongbaseline/mobilenetv2_x1_comb.py#L41

However,

image_crop = cv2.resize(image_crop, self.target_size)

uses opencv's convention of [width, height]

Practically, this does not matter because it's a square, but then you could have used just one parameter instead of two.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions