Skip to content

Add markdown support#96

Open
ldidry wants to merge 2 commits into
aliasaria:masterfrom
ldidry:markdown
Open

Add markdown support#96
ldidry wants to merge 2 commits into
aliasaria:masterfrom
ldidry:markdown

Conversation

@ldidry

@ldidry ldidry commented Sep 14, 2016

Copy link
Copy Markdown

With the help of marked

@ocdtrekkie

ocdtrekkie commented Jan 18, 2017

Copy link
Copy Markdown

This code works pretty great. I integrated it into 0.5 of the Sandstorm.io package of Scrumblr. I just had to grab some changes for marked.min.js to make links open in a new tab so that they'd work with Sandstorm's sandboxing: ocdtrekkie@6acde85 (This contains a hacked-together version of marked.js with a PR the marked.js author refused to merge from another user.)

It may be noteworthy that this functionality may be better outside Sandstorm as well. I doubt people who click links on their Kanban want to open them in the same tab.

@Framartin

Copy link
Copy Markdown

This PR should include the security fix of this issue when it will be ready (this is confidential for now).

@Framartin

Copy link
Copy Markdown

@ldidry Can you include the fix to this XSS in this MR.

@ocdtrekkie I have created a MR in your repo to fix the Sandstorm version: ocdtrekkie#11

@ldidry

ldidry commented Jul 10, 2017

Copy link
Copy Markdown
Author

@Framartin Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants