fix: decouple npm provenance from OIDC trusted publishing#1050
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
TIP This summary will be updated as you push new changes.
Haroenv
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR decouples npm provenance generation from OIDC trusted publishing, fixing publish failures on private/internal repositories.
--provenancetouseOidcTokenProvider, but they are independent concerns. One controls authentication (token vs. OIDC trusted publishing), the other controls whether a provenance attestation is attached. npm rejects provenance for private/internal repos, so any private-repo user enabling OIDC had their release fail at the publish step.generateProvenanceconfig option (defaultfalse).useOidcTokenProvidernow only controls authentication.Note
Provenance is no longer emitted automatically when
useOidcTokenProvideris enabled. It is now opt-in viagenerateProvenance: true. This is not a breaking change: it only means an attestation is no longer attached by default. Public-repo users who want to keep generating provenance simply setgenerateProvenance: true.