Repository navigation
Conversation
…7294) * feat(compare)!: require a comparison configuration for the hand-off The compare hand-off always sends the configured comparison's placeholder now; the prose fallback (getDefaultComparisonMessage, getComparisonMessage) is gone, so there is only one path and the chat hides it as a prompt shortcut. The configurationId is set on the widget that triggers the hand-off (compareBar, <CompareBar>) and shared through the selection, so per-hit toggles keep calling useCompare() without it. compare() throws a usage error when no widget set one. BREAKING CHANGE: compareBar and <CompareBar> require configurationId; the getComparisonMessage option and getDefaultComparisonMessage are removed. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(examples): use the demo comparison configuration Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(compare): clear the selection after the hand-off to the chat The compare bar stayed visible after opening the chat because the selection was never cleared. compare() now clears it once the message is submitted, which dismisses the bar. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * comment clean --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
…lable (#7295) * feat(chat): announce replies once and make the history keyboard-scrollable The message log announced every streamed chunk, and VoiceOver ignores its aria-busy. Silence it and announce once when a reply starts, once with the full reply when it completes, and on error through a status region. Make the scrollable history a focusable, named region so keyboard users can scroll text-only answers. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix(chat): address review on reply announcements - announce only a trailing assistant message, so a stopped request does not repeat the previous answer - strip only unambiguous Markdown (and none in plain-text mode) so literal characters like C# and order_id survive - move aria-busy to the history so the status region is not in a busy subtree Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * refactor(chat): stop deriving spoken text from Markdown Announce a plain 'Reply received.' by default and pass the reply to responseCompleteStatusText, so consumers that know how a reply is rendered can announce its text. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix(chat): announce in-flight requests on mount and clear stale replies Start the announcement baseline as idle so a request already in flight when the messages mount is announced, and clear the announced reply when the history is emptied. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * feat(chat): expose announcement translations in the JS widget Forward conversationLabelText, respondingStatusText, responseCompleteStatusText and errorStatusText to the messages translations. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix(chat): keep default translations when an override is undefined Merge translations through a helper that ignores keys explicitly set to undefined, so a default is never replaced by a missing label or callback (responseCompleteStatusText: undefined used to throw when a reply finished). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Revert "fix(chat): keep default translations when an override is undefined" This reverts commit 6db8804. Explicitly undefined translation overrides replace the default in every React and ui-components widget; fixing that belongs in its own change across all widgets rather than only in chat. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(chat): stay silent when a request ends without a reply A resume with no stream to reconnect to goes submitted → ready without touching the history, and the restored assistant message was announced as a new reply. Remember the last message while the request is submitted, and only announce a trailing assistant message that changed since. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 6 critical 3 high |
🟢 Metrics 445 complexity
Metric Results Complexity 445
TIP This summary will be updated as you push new changes.
More templates
algoliasearch-helper
instantsearch-ui-components
instantsearch.css
instantsearch.js
react-instantsearch
react-instantsearch-core
react-instantsearch-nextjs
react-instantsearch-router-nextjs
vue-instantsearch
commit: |
|
Size Change: +34.7 kB (+3.33%) Total Size: 1.08 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
|
did you see #7131 too? |
Contributor
Author
Yes I did, planning to port it's changes over here if possible. From what i can tell, that has support for isolated index and chat which are not a part of these changes since those are for separate tickets. This PR has full parity with the react and js autocomplete tho. |
Contributor
|
ok cool, how do you implement that without isolated index? |
Contributor
Author
it's using the isolated index logic from the js widget, it passes isolated = true to it. but i think introducing the isolated flag to vue itself is the better approach, i'll port that over |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Result