fix(crawler): accept all renderJavaScript shapes - #276
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 40 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes.
LorrisSaintGenez
marked this pull request as ready for review
July 30, 2026 20:54
8bittitan
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
algolia crawler listfailing when any crawler config uses the array or object form ofrenderJavaScriptConfig.RenderJavaScript boolwith a custom type accepting the three API shapes: boolean, array of URL patterns, object (enabled/waitTime/adblock/patterns)Test
renderJavaScriptis an array or object:crawler listlists all crawlers instead of failing withcannot unmarshal array into Go struct field ... of type boolcrawler get --config-onlyreturnsrenderJavaScriptin the exact shape shown in the dashboard (array/object preserved)