Omit empty DTLS 1.3 certificate authorities#153
Merged
algesten merged 2 commits intoJun 26, 2026
Conversation
jshanson7
force-pushed
the
codex/omit-empty-cert-authorities
branch
from
5ae5167 to
3bd14f2
Compare
jshanson7
force-pushed
the
codex/omit-empty-cert-authorities
branch
from
3bd14f2 to
8adae56
Compare
Contributor
Author
|
@algesten we've confirmed this fixes chrome <> str0m when using 1.3. |
Owner
|
@jshanson7 thanks for hunting it down, and @tyhik thanks for also finding it. Let's get the fix out! |
algesten
force-pushed
the
codex/omit-empty-cert-authorities
branch
from
dbfcf5b to
b24d074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLS 1.3 defines
certificate_authoritiesas a non-empty list when the extension is present. dimpl currently sends it with an empty list in DTLS 1.3CertificateRequest; Chrome/BoringSSL reject that as malformed:Chrome
RTCPeerConnection-> ICE/UDP connected to str0m
-> str0m using dimpl DTLS 1.3 on the passive/server side
-> dimpl default
require_client_certificate = true-> no CA names to advertise
omitting the extension when there are no CA names keeps client auth enabled and makes the
CertificateRequestvalid.