fix(ci): pin aiohttp<3.13 in the testing env#290
Merged
Conversation
aiohttp 3.13 changed ClientResponse.__init__ (new stream_writer kwarg) and aioresponses, including the latest 0.7.8, cannot mock it. This has been failing the vm client tests (23 of them) in CI since the resolver started picking aiohttp 3.13+, including the nightly runs on main. The pin is test-only; the runtime requirement stays aiohttp>=3.8.3.
|
Failed to retrieve llama text: POST 502: Bad Gateway |
foxpatch-aleph
approved these changes
Jun 11, 2026
foxpatch-aleph
left a comment
foxpatch-aleph
left a comment
There was a problem hiding this comment.
Minimal, correct fix for a CI breakage caused by aiohttp 3.13. The pin is scoped to the testing env only, leaving the runtime dependency unchanged. The comment explains the root cause and when the pin can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main CI (and every PR) has been red for at least 5 days: the 23 vm client test failures are aiohttp 3.13+ changing ClientResponse.init (new stream_writer kwarg), which aioresponses cannot mock, including the latest 0.7.8.
Verified locally: with aiohttp 3.14 + aioresponses 0.7.6 or 0.7.8 the 23 tests fail; with aiohttp 3.12.15 all 32 vm tests pass.
This pins aiohttp<3.13 in the hatch testing env only. The runtime requirement stays aiohttp>=3.8.3. The pin can be dropped once aioresponses supports aiohttp 3.13.
🤖 Generated with Claude Code