Skip to content

Ensure clinical trials that are inactive in DV do not appear in platform #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcbashdown merged 1 commit into from
Jun 23, 2026
Merged

Ensure clinical trials that are inactive in DV do not appear in platform #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/igh_data_transform/transformations/clinical_trials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,10 @@ def transform_clinical_trials(
"""
df = df.copy()

# Filter deleted/inactive records (statecode != 0)
if "statecode" in df.columns:
df = df[df["statecode"] == 0].copy()

# Build a reliable per-trial source link from the authoritative
# registration id (vin_name), before the raw columns are renamed/dropped.
# vin_source is consulted only as a fallback inside build_source_link.
Expand Down
11 changes: 11 additions & 0 deletions tests/unit/test_clinical_trials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,17 @@ def test_preserves_row_count(self):
result, _ = transform_clinical_trials(df)
assert len(result) == 2

def test_filters_inactive_records(self):
df = self._make_input_df({"statecode": [0, 1]})
result, _ = transform_clinical_trials(df)
assert len(result) == 1
assert result.iloc[0]["clinicaltrialid"] == "ct-1"

def test_filters_all_inactive_records(self):
df = self._make_input_df({"statecode": [1, 1]})
result, _ = transform_clinical_trials(df)
assert len(result) == 0

def test_works_when_option_sets_is_none(self):
df = self._make_input_df()
result, cleaned = transform_clinical_trials(df, option_sets=None)
Expand Down