deps: remove stale System.Net.Http 4.3.4 and System.Text.RegularExpressions 4.3.1 pins#924
Merged
Conversation
…ssions 4.3.1 pins These were transitive pins for very old backport packages. Analysis showed no direct or active transitive usage in the main solution after removal. The Owin path remains intentionally legacy for .NET Framework compatibility.
github-actions
Bot
added
dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #924 +/- ##
=======================================
Coverage 71.08% 71.08%
=======================================
Files 42 42
Lines 1048 1048
Branches 136 136
=======================================
Hits 745 745
Misses 240 240
Partials 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed two stale central package pins that were no longer required:
System.Net.Http4.3.4System.Text.RegularExpressions4.3.1Background
These were added as transitive pins (with
CentralPackageTransitivePinningEnabled) to address old backport packages commonly flagged by security scanners (e.g. CVE-2019-0820 for the Regex package).After review:
System.Text.RegularExpressionsusages are fully-qualified BCL calls in E2E Playwright tests.dotnet restoreonCAS.slnxsucceeds cleanly with no resolution errors.dotnet list package --include-transitiveon key projects (including the Owin library) shows neither package in the active dependency graph.Scope
Microsoft.AspNetCore.WebUtilities 2.3.10pin for netstandard2.0/net4* targets was left in place (required by the Owin handler).Verification
This continues the dependency hygiene work on the
chore/update-depsbranch.