Conversation
This was referenced Sep 17, 2026
jfallows
force-pushed
the
claude/jolly-hypatia-9iojjc
branch
from
September 30, 2026 13:47
5bb5ca1 to
e7b977c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds k3po scenario-script test fixtures for a mock Anthropic backend, mirroring the existing OpenAI mock-backend pattern (
.rptclient/server scripts underbinding-llm.spec, driven byLlmClientIT/LlmServerIT/NetworkIT/ApplicationITinbinding-llm), plus one bug fix found while exercising it:network/anthropic.streamingandnetwork/anthropic.nonstreamingclient/server.rptscripts (mock Anthropic upstream, SSE and JSON response shapes), plus dedicatednetwork/client.anthropic.streamingandnetwork/client.anthropic.nonstreamingserver scripts forLlmClientIT's exclusive use, sinceLlmClientFactoryalways encodes a fixed/path regardless of dialect while the shared network fixtures need the real/v1/messagesdetection path — same split OpenAI's own fixtures already use.application/anthropic.streamingandapplication/anthropic.nonstreamingclient/server.rptscripts for the application-side round trip.LlmClientIT/LlmServerIT/NetworkIT/ApplicationITtest methods wiring up the above.fix(binding-llm.spec): give LlmClientIT its own network-side anthropic mock— fixes a path mismatch (/vs/v1/messages) between the shared network fixture and whatLlmClientFactoryactually sends, matching the equivalent fix already applied to the OpenAI fixtures.Stacking
This branch is built on top of #2578 (Anthropic dialect implementation), which is itself stacked on #2577/#2576 — so this diff includes those commits until they merge to
develop, at which point this PR's diff will shrink to just the 3 commits at the tip (af9c0f21,6ef3389b,5bb5ca1f). Opened now againstdevelopto prove CI passes on the full stack; base will be reset once the underlying PRs merge one at a time.Test plan
./mvnw license:check -pl incubator/binding-llm,incubator/binding-llm.spec— clean./mvnw checkstyle:check -pl incubator/binding-llm,incubator/binding-llm.spec— clean./mvnw verify -pl incubator/binding-llm,incubator/binding-llm.spec,incubator/binding-llm.conf -am— 199/199 unit tests, 11/11LlmClientIT, 15/15LlmServerITFixes #2493
🤖 Generated with Claude Code
https://claude.ai/code/session_01HXHtTkxAUq2EYMqxY8jgY8
Generated by Claude Code