Keep empty e-reader picker submissions on the list - #44
Merged
Merged
Conversation
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit the e-reader picker with POST so its password-bearing
?epub<password>=listURL remains in place. Selected article IDs are read from POST; submitting no selection stays on the picker instead of reaching the login page. When JavaScript is available, the Download buttons are disabled until an article is selected and empty submissions are blocked. Direct GET URLs containing an array of article IDs are no longer accepted.Tests:
vendor/bin/phpunit(61 tests)node --check plain-list.jsgit diff --checkWordPress Playground
Test this PR in WordPress Playground: Try this PR · Try with demo data