Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relation_digraph()stores the input bitset vector in the staticFpointer and updates the pointed-to bitsets directly while traversing the relation.The final
function = Fassignment only writes to a by-value parameter and therefore has no effect on the caller. Remove this dead assignment.Also clear
indexesandverticesafter freeing them, and clear the borrowedRandFpointers before returning, so the static state does not retain stale or dangling pointers.The transitive-closure behavior is unchanged because the caller's bitsets are modified in place.