Skip to content

Fixes issue #13: Published fat JAR bundles slf4j-nop, silently disables logging in consumers#14

Open
Jintumoni wants to merge 2 commits into
akeylesslabs:mainfrom
Jintumoni:bugfix/fat-jar-slf4j-nop
Open

Fixes issue #13: Published fat JAR bundles slf4j-nop, silently disables logging in consumers#14
Jintumoni wants to merge 2 commits into
akeylesslabs:mainfrom
Jintumoni:bugfix/fat-jar-slf4j-nop

Conversation

@Jintumoni

@Jintumoni Jintumoni commented May 5, 2026

Copy link
Copy Markdown

Fixes issue #13

Summary by CodeRabbit

  • Documentation

    • Corrected a spelling error in the README.
  • Chores

    • Removed an unused dependency from the project build configuration.

@coderabbitai

coderabbitai Bot commented May 5, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0030ee95-92aa-4dc1-9b18-f3eb354b458b

📥 Commits

Reviewing files that changed from the base of the PR and between 58f4951 and 2a6f3a2.

📒 Files selected for processing (2)
  • README.md
  • pom.xml
💤 Files with no reviewable changes (1)
  • pom.xml

📝 Walkthrough

Walkthrough

A typo in the README was corrected ("exteact" → "extract"), and the org.slf4j:slf4j-nop:2.0.13 dependency was removed from pom.xml. Both are maintenance updates with no feature impact.

Changes

Maintenance Updates

Layer / File(s) Summary
Documentation
README.md
Typo fix: corrected "exteact" to "extract" in the package description.
Build Configuration
pom.xml
Removed the unused org.slf4j:slf4j-nop:2.0.13 dependency entry from the <dependencies> section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes


🐰 A typo hops away, extract shines bright,
Slf4j-nop departs into the night,
Two tiny tweaks, so clean and neat,
The project's maintenance is complete! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main fix: removing slf4j-nop dependency that was causing silent logging disablement in consumers, which aligns with both commits and the primary changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jintumoni

Copy link
Copy Markdown
Author

Hi @alikdolg can you take a look into this?

@Jintumoni

Copy link
Copy Markdown
Author

Thanks @alikdolg for approving. I think it has to be merged by one of the contributors of this repo. Also a tag needs to pushed to trigger the ci it seems. Would you be able to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants