MSSQL: encrypt-in-transit default for msodbcsql18 compatibility#4
Merged
Merged
Conversation
The SRA bastion is moving its Adminer stack from msodbcsql17 to msodbcsql18 (required for arm64 — v17 has no arm64 packages). msodbcsql18 flips the default for an unset Encrypt from "no" (plaintext) to "yes" with mandatory server-cert validation, which would break every MSSQL connection on the default no-SSL path to a server without a CA-trusted certificate. Set the MSSQL connection to always encrypt in transit, and validate the server certificate only when the user opts into SSL mode. On the default path this keeps existing connections reachable (TrustServerCertificate=true skips validation) while still upgrading them from plaintext to encrypted — a net security gain over the previous msodbcsql17 behavior. The explicit SSL opt-in remains strict (TrustServerCertificate=false). Consumed by zero-trust-bastion via the pinned adminer tag; requires a new tag and a matching Dockerfile bump there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
👮 Files not reviewed due to content moderation or server errors (1)
📝 Walkthrough
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the SRA ARM64 effort (ASM-18581). The
zero-trust-bastionAdminer stack must movemsodbcsql17→msodbcsql18because v17 has no arm64 packages. msodbcsql18 changes the default for an unsetEncryptfromno(plaintext) toyeswith mandatory server-certificate validation — which would break every MSSQL connection on the default (no-SSL) path to a server without a CA-trusted cert.This sets the MSSQL connection in the akeyless login plugin to always encrypt in transit, and to validate the server cert only when the user opts into SSL mode:
Encrypt=true, TrustServerCertificate=true— encrypted, no cert validationEncrypt=true, TrustServerCertificate=falseNet effect: existing connections stay reachable (no cert-validation break) and get upgraded from plaintext to encrypted — a security gain, not just a compatibility patch. Approach chosen with the SRA lead over the alternatives (exact-v17 plaintext preserve vs. v18 strict-by-default).
Delivery
plugins/login-akeyless-ssl.phpships standalone (not compiled intoadminer-5.4.2.php), so this is the only file that changes. Once merged, this needs a new tag (e.g.v5.4.2.2);zero-trust-bastionthen bumps its pinned adminer URLs to that tag alongside themsodbcsql18Dockerfile change.Verification
php -lclean🤖 Generated with Claude Code