feat: adds tee resources description#3377
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughAdds ChangesConfidential Compute carveout preview and GPU warning
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: Ping-pong health check failed Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
==========================================
- Coverage 69.80% 68.44% -1.37%
==========================================
Files 1100 1010 -90
Lines 26926 24593 -2333
Branches 6455 5997 -458
==========================================
- Hits 18797 16833 -1964
+ Misses 7141 6804 -337
+ Partials 988 956 -32
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
stalniy
force-pushed
the
feat/adds-tee-resource-details
branch
2 times, most recently
from
625dfbf to
4039f86
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigurationPane/ConfidentialComputeCard/ConfidentialComputeCard.spec.tsx`:
- Around line 136-145: The current tests for ConfidientialComputeCard only
pre-seed the tee state, so they do not verify the actual cpu-gpu selection flow.
Update the “selected” case in ConfidentialComputeCard.spec.tsx to interact with
the radio group through the component’s selection path, using the existing
setTee()/enableGpu behavior, while keeping direct state seeding only for the
persisted mismatch scenario. Use the existing setup helper and the cpu-gpu
option assertions to ensure the GPU fields stay in sync when the user selects
cpu-gpu.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cd64dceb-1d11-4e93-a745-d7dd3ccd4331
📒 Files selected for processing (5)
apps/deploy-web/src/components/deployments/ConfidentialComputeResources.tsxapps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigurationPane/ConfidentialComputeCard/ConfidentialComputeCard.spec.tsxapps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigurationPane/ConfidentialComputeCard/ConfidentialComputeCard.tsxapps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigurationPane/cardTooltips.tsxapps/deploy-web/src/utils/confidentialCompute.ts
baktun14
approved these changes
Jun 30, 2026
stalniy
force-pushed
the
feat/adds-tee-resource-details
branch
from
4039f86 to
f2ef979
Compare
stalniy
force-pushed
the
feat/adds-tee-resource-details
branch
from
f2ef979 to
fa889ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ref CON-573
What
Summary by CodeRabbit