Add configurable master fader modes - #5
Closed
daxliniere wants to merge 4 commits into
Closed
daxliniere wants to merge 4 commits into
daxliniere wants to merge 4 commits into
Conversation
Author
|
Closing until the hardware changes have been tested and explicitly approved for upstream submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Users may want to reserve the physical master fader for another purpose instead of binding it to the REAPER master volume. LTFP mode provides deliberate jog-tap assignment without following every later FX click, while Disabled mode makes reservation explicit and prevents the surface implementation from fighting another mapping.
Compatibility
The new behavior is stored as an additional bit in the existing configuration flags field. Existing configurations do not have that bit and therefore retain the current Master volume behavior.
The surface-enable toggle also uses an opt-out flag, so existing configurations remain enabled. Port selections are retained while disabled, but their MIDI handles are not opened, allowing REAPER to use the device as a normal MIDI input/output.
Validation
reaper_reamculive-x64.dlltarget successfullygit diff --checkpassesDependency
This branch is stacked on #4. Until #4 is merged, GitHub will also show its track-navigation commit in this PR; after merge, the PR diff will reduce to the master-fader/settings changes.