Skip to content

Added 2D Circle on plane in 3D space - #334

Draft
Yeok-c wants to merge 21 commits into
ajhynes7:masterfrom
Yeok-c:master
Draft

Added 2D Circle on plane in 3D space#334
Yeok-c wants to merge 21 commits into
ajhynes7:masterfrom
Yeok-c:master

Conversation

@Yeok-c

@Yeok-c Yeok-c commented Mar 6, 2023

Copy link
Copy Markdown

Sphere's intersection on a 2D plane in 3D space is a circle on a plane. Test files and new class with barebone implementation added.

Yeok-c and others added 2 commits March 6, 2023 16:20
Sphere's intersection on a 2D plane in 3D space is a circle on a plane. Test files and new class with barebone implementation added.
@ajhynes7

ajhynes7 commented Mar 6, 2023

Copy link
Copy Markdown
Owner

Hi @Yeok-c,

Before I do a thorough review of this code, you need to get the PR checks (pre-commit and the tests) to pass. For starters, you need to delete all the commented-out code. For now I'm marking this PR as a draft.

Once these checks have passed, please mark this PR as ready for review and request me as a reviewer.

@ajhynes7
ajhynes7 marked this pull request as draft March 6, 2023 12:30
@CristianoPizzamiglio

Copy link
Copy Markdown
Collaborator

Hi @Yeok-c! Do you need help with this PR? If think this would be a very valuable addition to this library
I have already developed something similar here, maybe it can be helpful.

@Yeok-c

Yeok-c commented Apr 11, 2023

Copy link
Copy Markdown
Author

yeah I'd love some help. I've developed some more features on my fork https://github.com/Yeok-c/scikit-spatial

Circle3D object (a 2D circle on a plane in 3D space), resulting from sphere-plane intersection
Elipse3D object (a 2D elipse on a plane in 3D space), resulting from cylinder-plane intersection

and also sphere-sphere-sphere trisection, which results in one points.

All the intersections are intentionally implemented without iterative algorithms, which makes it possible to do differentiable operations later.

The implementations are messy but they work for my purpose. I don't have time to align it with the style in this repo. I wouldn't mind if anyone added them to this repository with minor credits to me.

@CristianoPizzamiglio

Copy link
Copy Markdown
Collaborator

yeah I'd love some help. I've developed some more features on my fork https://github.com/Yeok-c/scikit-spatial

Circle3D object (a 2D circle on a plane in 3D space), resulting from sphere-plane intersection Elipse3D object (a 2D elipse on a plane in 3D space), resulting from cylinder-plane intersection

and also sphere-sphere-sphere trisection, which results in one points.

All the intersections are intentionally implemented without iterative algorithms, which makes it possible to do differentiable operations later.

The implementations are messy but they work for my purpose. I don't have time to align it with the style in this repo. I wouldn't mind if anyone added them to this repository with minor credits to me.

Hi! Sorry, pretty busy at work. I will start working on this very soon!

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3.4% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants