Added 2D Circle on plane in 3D space - #334
Conversation
Sphere's intersection on a 2D plane in 3D space is a circle on a plane. Test files and new class with barebone implementation added.
for more information, see https://pre-commit.ci
|
Hi @Yeok-c, Before I do a thorough review of this code, you need to get the PR checks (pre-commit and the tests) to pass. For starters, you need to delete all the commented-out code. For now I'm marking this PR as a draft. Once these checks have passed, please mark this PR as ready for review and request me as a reviewer. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
yeah I'd love some help. I've developed some more features on my fork https://github.com/Yeok-c/scikit-spatial Circle3D object (a 2D circle on a plane in 3D space), resulting from sphere-plane intersection and also sphere-sphere-sphere trisection, which results in one points. All the intersections are intentionally implemented without iterative algorithms, which makes it possible to do differentiable operations later. The implementations are messy but they work for my purpose. I don't have time to align it with the style in this repo. I wouldn't mind if anyone added them to this repository with minor credits to me. |
Hi! Sorry, pretty busy at work. I will start working on this very soon! |
|
Kudos, SonarCloud Quality Gate passed! |
|
|
















Sphere's intersection on a 2D plane in 3D space is a circle on a plane. Test files and new class with barebone implementation added.